fix(fast-mode): handle missing serviceTiers#13
Open
boggedbrush wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a blank-screen renderer crash in the Linux desktop app when fast mode eligibility is evaluated against model schemas where
serviceTiersis missing ornull.The recovered webview bundle previously assumed every model had a
serviceTiersarray and accessedserviceTiers.lengthdirectly. When the model payload omitted that field, or returned it asnull, the renderer could throw during startup/rendering and leave the app stuck on a blank screen.Commits
fix: guard fast mode service tiersApplies the actual runtime fix.
serviceTiersas an empty list.assemble-codex-runtime.mjsso future recovered-runtime refreshes preserve the fix.refresh-manifest.json.test: harden fast mode serviceTiers patchHardens the patch path and expands regression coverage.
serviceTiers.lengthform when present.serviceTiersomittedserviceTiers: nullserviceTiers: []serviceTiersadditionalSpeedTiersstill enabling fast modeserviceTiersaccess patternsWhy
Some model schema responses may omit
serviceTiersor provide it asnull, while still including other model metadata such asadditionalSpeedTiers. The fast mode check should tolerate that shape instead of throwing.With this change, missing or
nullserviceTiersbehaves like an empty list:Existing populated
serviceTiersbehavior is preserved, and fast mode can still be enabled viaadditionalSpeedTierswhen applicable.Testing
codex-runtime-assembly.test.jsrecovered-bundle.red.test.ts