Changes to build Unreal 4.25, linux compatibility, change to create s… - #2
Open
vivienneanthony wants to merge 1 commit into
Open
Changes to build Unreal 4.25, linux compatibility, change to create s…#2vivienneanthony wants to merge 1 commit into
vivienneanthony wants to merge 1 commit into
Conversation
alteveer
requested changes
Jan 29, 2021
| m_TerrainMeshComponent->SetCollisionProfileName(UCollisionProfile::BlockAll_ProfileName); | ||
| m_TerrainMeshComponent->Mobility = EComponentMobility::Static; | ||
| m_TerrainMeshComponent->SetMeshSectionCollisionEnabled(0, true); | ||
| //m_TerrainMeshComponent->SetMeshSectionCollisionEnabled(0, true); |
Owner
There was a problem hiding this comment.
did you test collision on the mesh? can you trace to it and/or can UCharacter walk on it?
|
|
||
| } | ||
| void ATerrainActor::OnConstruction(const FTransform& Transform) | ||
| void ATerrainActor::OnConstruction(const FTransform &Transform) |
| /// Modified from original | ||
| URuntimeMeshProviderStatic *provider = (URuntimeMeshProviderStatic *)m_TerrainMeshComponent->GetProvider(); | ||
|
|
||
| if (provider) |
Owner
There was a problem hiding this comment.
if(!provider)
return;
this way we don't get into deep if nesting
| // Modified from original | ||
| URuntimeMeshProviderStatic *provider = (URuntimeMeshProviderStatic *)m_TerrainMeshComponent->GetProvider(); | ||
|
|
||
| if (provider) |
Owner
There was a problem hiding this comment.
same re: "if nesting" -- if(!condition) return;
Author
|
I just noticed the additional comments. I'm going check it out later also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the source to work with the latest version of runtimemeshcomponent, Linux, and Unreal 4.25
Note
I used ProviderStatic as the example https://github.com/TriAxis-Games/RuntimeMeshComponent-Examples/blob/master/Source/RuntimeMeshSandbox/BasicExamples/BasicPMCStyleRMC.cpp. It should be a regular provider which enables the multithreading. I will be looking into that then implementing it.