Taxonomy support (for discussion)#9
Open
leewillis77 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Hi; Just wondered if there was any feedback on this? Thanks |
Member
|
Hey @leewillis77! Sorry for the delay on reviewing this, we've been so busy 😅 but both of your pull requests look brill. The taxonomy support is a bit weird, as we can't hook into the taxonomy blueprint, as there's no event for it currently (that we're aware of anyway) so we can't amend the blueprint on the fly. We've had thoughts around workarounds, we just need to implement them, but we may look to implement the event into core Statamic and then from there be able to utilise something like the above. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial stab at taxonomy support (as requested in #7)
This PR:
It does not:
On [3] if someone can provide a pointer as to how the Alt-Sitemap blueprint is auto-assigned to entries I can look at expanding this PR to also do that on term edit pages.