security: reject cross-site POST/PUT/DELETE on /api (#11) - #38
Merged
Conversation
No cookies, no auth: a CSRF token would prove nothing. The real attack is a page on another origin driving the visitor's browser at 127.0.0.1:3800 to rewrite prompts, install library items or trigger a backup. Browsers always send Origin / Sec-Fetch-Site on those requests, so lib/csrf.js rejects unsafe methods whose Origin (or Referer, or Sec-Fetch-Site) is not the Host the request arrived on. Origin-less clients (curl, scripts) and every GET are unaffected; HOST=0.0.0.0 LAN setups work from whatever hostname is served. Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No cookies, no auth: a CSRF token would prove nothing. The real attack is a
page on another origin driving the visitor's browser at 127.0.0.1:3800 to
rewrite prompts, install library items or trigger a backup. Browsers always
send Origin / Sec-Fetch-Site on those requests, so lib/csrf.js rejects
unsafe methods whose Origin (or Referer, or Sec-Fetch-Site) is not the Host
the request arrived on. Origin-less clients (curl, scripts) and every GET
are unaffected; HOST=0.0.0.0 LAN setups work from whatever hostname is served.
Closes #11