Update criterion to 0.8, and use std::hint::black_box - #43
Merged
Conversation
Criterion 0.8 deprecates its own `black_box` re-export in favour of the one in the standard library, stable since Rust 1.66. Without the change to the benchmarks, `cargo clippy --all-targets -- -D warnings` fails – and that is exactly what CI runs. The other dev-dependencies are relaxed to major/minor versions at the same time; the extra patch-level precision wasn't buying us anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criterion 0.8 deprecates its own
black_boxre-export in favour of the one in the standard library, stable since Rust 1.66. Without the change to the benchmarks,cargo clippy --all-targets -- -D warningsfails – and that is exactly what CI runs.The other dev-dependencies are relaxed to major/minor versions at the same time; the extra patch-level precision wasn't buying us anything.