CLI-style execution for Python-defined experiments - #600
Merged
Conversation
Add ability to display the executor output. Can be used as follows: ```python output = executor.execute_step_graph(step_graph) output.display() ```
Contributor
Author
|
Seems like the lint and type check failed, but for reasons independent of this PR. Shall I resolve those anyway? |
Contributor
Author
|
That's great -- thanks a lot @AkshitaB! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I think the Tango CLI is really nice and would really like if we could support Python-defined experiments with CLI-style execution. So I modularized the CLI run functions and decoupled them from
__main__.py.Now we can also run scripts like:
This should be the same as
tango run examples/euler/euler.jsonnet!If we want to use the default
TangoGlobalSettings, we can also shorten the block toThis includes the changes from (@BigRedT) Tanmay's PR #491. CLI functionality should be completely the same. I ran the tests in
tests/main_test.pysuccessfully. Formatted withisortandblackand checked withruffandmypy. Docs needed.What do you think? Happy to make adjustments as you see fit!