Skip to content

style: migrate to ruff - #562

Merged
epwalsh merged 6 commits into
allenai:mainfrom
SauravMaheshkar:ruff
Jun 12, 2023
Merged

style: migrate to ruff#562
epwalsh merged 6 commits into
allenai:mainfrom
SauravMaheshkar:ruff

Conversation

@SauravMaheshkar

@SauravMaheshkar SauravMaheshkar commented May 5, 2023

Copy link
Copy Markdown
Contributor

Follow up of #558

Request for Review: @epwalsh

@epwalsh epwalsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SauravMaheshkar! Looks like the ruff configuration needs a fix

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread pyproject.toml Outdated
@SauravMaheshkar
SauravMaheshkar requested a review from epwalsh May 10, 2023 14:30
@SauravMaheshkar

Copy link
Copy Markdown
Contributor Author

Are the failing tests related to this PR ??

@epwalsh

epwalsh commented May 10, 2023

Copy link
Copy Markdown
Contributor

Are the failing tests related to this PR ??

I don't think so. W&B, Beaker, GS, and GPU Tests are failing due to missing permissions (which is expected), and I'm guessing the PyTorch tests will be resolved by #560. I'll hold off until #560 merges since Dirk is working on that right now.

@epwalsh epwalsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@epwalsh
epwalsh merged commit 4c3edce into allenai:main Jun 12, 2023
@SauravMaheshkar
SauravMaheshkar deleted the ruff branch June 12, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants