Finetuning - #255
Merged
Merged
Conversation
AkshitaB
marked this pull request as draft
April 4, 2022 06:14
AkshitaB
marked this pull request as ready for review
April 12, 2022 18:17
dirkgr
suggested changes
Apr 12, 2022
|
|
||
|
|
||
| @Step.register("subset-data") | ||
| class SubsetData(Step): |
Contributor
There was a problem hiding this comment.
We have the DatasetRemix step for Tango's DatasetDict. Can we have the same for HF's datasets?
Contributor
Author
There was a problem hiding this comment.
Will work on it separately: #268 This is technically unrelated to finetuning.
|
|
||
| def run( # type: ignore[override] | ||
| self, | ||
| model: Lazy[Model], |
Contributor
There was a problem hiding this comment.
If I want to do some sort of curriculum learning, can I pass in the output of another training step here?
dirkgr
approved these changes
Apr 19, 2022
dirkgr
enabled auto-merge (squash)
April 19, 2022 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
transformers::finetunestep, which mostly mimics theTorchTrainStepwith additions for tokenizing the data (and updating the model embeddings). It also contains model-specific defaults for the data collator.RunGenerationnow allows the trained model object as input.Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting