fix: correct API method name and add pagination safeguards - #13
Open
pocikode wants to merge 1 commit into
Open
Conversation
- Fix ListByRepository -> ListByRepo (correct method name in go-github v57) - Add maxPages guard (100) to prevent infinite pagination loops - Add context cancellation check inside the pagination loop - Guard against resp.NextPage == opt.Page (stuck pagination) Fixes the build error and adds robustness against edge cases where the GitHub API may return unexpected pagination states with the 'since' filter.
Author
|
/claim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems here:
ListByRepositorydoes not exist in go-github v57. The method is calledListByRepo. This was a straight-up build error — the code could not compile.No guard against infinite pagination loops. If the GitHub API returns weird pagination states (which can happen with the
sincefilter), thefor {}loop would run forever.Fixes:
ListByRepomaxPagescap (100) so the loop terminates even if something goes wrongctx.Err()check per iteration so callers can cancelresp.NextPage == opt.Pageguard for stuck paginationThe existing tests cover the happy path and rate limiting. The pagination guard is defensive — should not trigger in normal usage, but better safe than hanging.