feat(skills): manual escape hatch for stuck reject-cooldowns

[alimobrem]

Summary

Option B from the skill-effectiveness reject-cooldown investigation: a human-initiated, audited way to clear a stuck (app_name, skill_name) cool-down.

• get_skill_cooldown() (src/agentit/portal/store/skills.py) has no expiry and no time window -- once 2+ rejects for a pair share a reason prefix, that skill is skipped everywhere (skill_engine.py match/run_all, remediation/dispatcher.py, delivery.py) forever, with no existing way out.
• Confirmed live: pulse-agent/pulse-ui's containerfile skill is stuck cooling down purely from rejects the now-deleted CodeChangeAgent caused (commit 9e1d7623/a2d20ef6), not from any fault in containerfile itself.

What this adds:

• AssessmentStore.clear_skill_cooldown(app_name, skill_name, *, reason, actor="") -- inserts a dedicated skill_effectiveness marker row (outcome="cooldown_cleared") that get_skill_cooldown()/list_cooled_skills() treat as a waterline: only rejects strictly after the most recent marker for that exact pair count going forward.
  • Purely additive: the automatic trigger's own condition (2+ rejects, same reason prefix, SKILL_COOLDOWN_SAME_REASON) never changes. A skill that keeps genuinely failing cools down again after the same threshold of new matching rejects post-clear.
  • Every other (app, skill) pair is untouched.
  • The marker is excluded from get_skill_effectiveness()'s approval-rate math so clearing a cooldown never makes a skill's own score look worse.
  • Never deletes prior reject history -- still fully visible on /capabilities/skills/{skill}/history.
• Portal route POST /capabilities/skills/clear-cooldown (mirrors activate-skill/deprecate-skill's pattern in routes/capabilities.py) -- requires a real reason, logs a skill-cooldown-cleared event via store.log_event() so it shows up on the Events feed.
• CLI parity: agentit clear-skill-cooldown APP_NAME SKILL_NAME --reason ... [--actor ...].
• Capabilities' existing "Cooling down" banner gained an inline Clear cooldown… action per cooled skill, showing the reject count/reason prefix it's about to override before confirming.
• skill_detail.html's effectiveness trend table renders the new marker outcome distinctly (a neutral/warning badge) instead of looking like an extra rejection.

Test plan

• New store-level tests (tests/test_skill_learning_minimal.py::TestClearSkillCooldown): clear unblocks the exact pair, doesn't affect other apps/skills, doesn't affect list_cooled_skills() (the query skill_engine.py actually gates Scan on), skill can cool down again after being cleared (not a permanent bypass), reject history is preserved, blank reason raises, marker doesn't dilute approval-rate stats.
• New route tests (tests/test_portal.py): clears + logs event, requires a reason, requires app/skill name, banner renders the clear form.
• New CLI tests (tests/test_cli.py): wires args through to the store method, defaults actor to the OS user, requires --reason.
• Full suite: 3511 passed, 459 skipped, 0 failed.

Live verification

Cluster/portal access (oc whoami) is unavailable in this session (expired token) -- live verification against pulse-agent/pulse-ui's real containerfile cooldown is blocked until this merges + deploys + cluster access is available. Will follow up once available; see conversation notes.

Made with Cursor