Implement task 5#2
Open
alibibio wants to merge 2 commits into
Open
Conversation
IvanKozlov98
reviewed
Mar 1, 2024
IvanKozlov98
left a comment
IvanKozlov98
left a comment
There was a problem hiding this comment.
FastQ-фильтратор 0/5
Биологические последовательности 15/19
Штраф за отсуствие примеров в ноутбуке -2
Итого: 13
В целом работа неплохая, понимание есть. Кажется, просто времени не хватило всё доделать доконца :)
| return (self.sequence.count('G') + self.sequence.count('C'))/len(self.sequence) | ||
|
|
||
|
|
||
| class RNASequence(NucleicAcidSequence): |
There was a problem hiding this comment.
- Наследуемая реализация метода
complementкорректно работает только для ДНК (без учета возвращаемого типа). - Пользователи классов ДНК и РНК могут передавать в функцию
complementсвои собственные словари (или даже не словари :) ) -- так не должно быть - Почему вы не сделали
complementаналогичноis_valid_bioseq(тут всё хорошо) ?
| class BiologicalSequence: | ||
| def __init__(self, sequence): | ||
| self.sequence = sequence | ||
| self.ALPHABET = {'A', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'K', 'L', 'M', 'N', 'P', 'Q', 'R', 'S', 'T', 'V', 'W', 'Y'} |
There was a problem hiding this comment.
Большие буквы намекают на static-поле.
Будто вы хотели так изначально, но что-то пошло не так?
| complement_seq = '' | ||
| for nucleotide in self.sequence: | ||
| complement_seq += COMPLEMENT_NUCLEOTIDES.get(nucleotide) | ||
| return complement_seq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.