ci(translation-sync): remove redundant push trigger#460
Conversation
PR validation already covers translation sync before merge; re-running on the post-merge push to main wastes CI. Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
📄
|
|
Nitpick: With the That said, I'd lean toward keeping it: it's a sensible defensive guard. If the Optional suggestion: add a short inline comment noting that the guard is intentional/defensive, so a future reader doesn't "clean it up" as dead code. |
|
Fair enough. I'll make the changes required. |
Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
Description
The
translation-syncworkflow triggered on bothpushandpull_request. Since merges go through PRs, the PR trigger already validates translation sync before merge — re-running on the post-merge push tomainonly re-exercises the blocking README check and wastes CI.This removes the
push:trigger block from.github/workflows/translation-sync.yml, leaving onlypull_request:with the existingpaths:filter. Jobs, container, steps, and env vars are unchanged.Closes #459.
Type of Change
How Has This Been Tested?
make checkpasses locallyManual testing (describe below)
Confirmed
on:contains onlypull_requestwith the originalpaths:filterConfirmed jobs/steps below
on:are unchangedChecklist
go fmt,go vet)Related Issues
Closes #459.