Update/v5 1 - #47
Open
oxmmty wants to merge 6 commits into
Open
Conversation
Member
|
Hi @oxmmty Thx for the PR. Here are some notes: Folder .githubWhy did you remove the folder .github? There are all the templates and build instructions used by Github and they need to stay in place! Useless copyright changesIt seems to me you're still not understand what I explained within the last PR and also on our Discord! Even within this PR there are a lot of files, where the one and only change is the copyright header. The bash snippet git diff master...update/v5-1 --name-only | while read file; do
diff=$(git diff master...update/v5-1 -- "$file")
additions=$(echo "$diff" | grep '^+' | grep -v '^+++')
deletions=$(echo "$diff" | grep '^-' | grep -v '^---')
if [ -z "$deletions" ] && \
[ "$(echo "$additions" | wc -l)" -eq 1 ] && \
echo "$additions" | grep -qF '// SPDX-FileCopyrightText: © 2025 ALIAS Developers'; then
echo "$file"
fi
donefilter out the files, which have nothing else than an addionally line of text with the content Jenkinsfile_disabled
src/alert.h
src/anonymize.h
src/bloom.h
src/build.h.in
src/chainparams.h
src/chainparamsseeds.h
src/checkpoints.h
src/clientversion.h.in
src/clientversion.h.obsolete
src/coincontrol.h
src/compat.h
src/core.cpp
src/currency.h
src/hash.cpp
src/hash.h
src/init.h
src/interface.h
src/key.h
src/keystore.cpp
src/mruset.h
src/noui.cpp
src/pbkdf2.cpp
src/pbkdf2.h
src/protocol.h
src/qt/aboutdialog.cpp
src/qt/aliasbridgestrings.h
src/qt/aliascorestrings.h
src/qt/bitcoinaddressvalidator.cpp
src/qt/bitcoinunits.cpp
src/qt/coincontroltreewidget.cpp
src/qt/csvmodelwriter.cpp
src/qt/editaddressdialog.cpp
src/qt/guiconstants.h
src/qt/macdockiconhandler.h
src/qt/macdockiconhandler.mm
src/qt/macnotificationhandler.h
src/qt/macnotificationhandler.mm
src/qt/monitoreddatamapper.cpp
src/qt/notificator.cpp
src/qt/res/alias-qt.rc
src/qt/scicon.cpp
src/qt/scicon.h
src/qt/test/test_main.cpp
src/qt/test/uritests.cpp
src/qt/test/uritests.h
src/qt/winshutdownmonitor.cpp
src/resource.h
src/ringsig.h
src/rpcprotocol.h
src/src.rc
src/test/allocator_tests.cpp
src/test/base32_tests.cpp
src/test/base64_tests.cpp
src/test/basic_tests.cpp
src/test/bignum_tests.cpp
src/test/extkey_tests.cpp
src/test/hash_tests.cpp
src/test/hmac_tests.cpp
src/test/key_tests.cpp
src/test/mruset_tests.cpp
src/test/netbase_tests.cpp
src/test/stealth_tests.cpp
src/test/uint160_tests.cpp
src/test/uint256_tests.cpp
src/threadsafety.h
src/txdb.h
src/types.h
src/uint256.h
src/version.cpp
src/version.h
src/win/unistd.hSo there are 72 useless changes! Again... Build instructionsHow to build the wallet with all these changes? Is https://github.com/aliascash/documentation/wiki still valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.