fix(deps): bump non-breaking dependencies and fix security issues - #755
fix(deps): bump non-breaking dependencies and fix security issues#755g-ongenae wants to merge 1 commit into
Conversation
- Update deps within semver ranges (pino 9.14, typescript 5.9, sinon 21.1, eslint 8.57.1, lint-staged 17.3, semantic-release 24.2.9, uuid 14.0.2, @commitlint/config-conventional 21.2.2) - Add scoped overrides for vulnerable transitive deps: minimatch ^9.0.7 (ReDoS, GHSA-3ppc/7r86/23c5) and uuid ^11.1.1 under gaxios/google-gax/teeny-request (GHSA-w5hq-g745-h8pq); the uuid override can be dropped once @google-cloud/pubsub@6 lands - Import pino Logger/LoggerOptions types directly (namespace types removed in pino 9.14) - Align @types/sinon with the sinon 21 runtime; drop @types/uuid (uuid 14 ships its own types) Remaining audit findings all trace to the npm CLI bundled in the semantic-release toolchain (release-time only); fixed by the semantic-release@25 major upgrade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions and adjusts PubSub wrapper typings to accommodate updated pino type exports, while adding npm overrides intended to remediate vulnerable transitive dependencies.
Changes:
- Updated
pinotype imports/usages (LoggerOptions,Logger) to match the newerpinotype surface. - Bumped several dev/runtime dependencies within semver ranges.
- Added npm
overridesforminimatchanduuidin an attempt to address transitive vulnerability advisories.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/GoogleCloudPubSub/lib.ts | Updates pinoOptions typing to use LoggerOptions directly. |
| src/GoogleCloudPubSub/GoogleCloudPubSub.ts | Updates logger typing to use Logger from pino. |
| package.json | Dependency bumps plus new overrides for vulnerable transitive deps. |
Suppressed comments (2)
package.json:84
- This override forces uuid 11.x for google-gax even though google-gax declares uuid ^9.0.1 (see package-lock.json). That’s outside the supported semver range and could be a breaking runtime change. If you need this for the GHSA mitigation, consider at least pinning the exact patched version to reduce unexpected upgrades.
"uuid": "^11.1.1"
package.json:87
- This override forces uuid 11.x for teeny-request even though teeny-request declares uuid ^9.0.0 (see package-lock.json). That’s outside the supported semver range and could be a breaking runtime change. If you need this for the GHSA mitigation, consider at least pinning the exact patched version to reduce unexpected upgrades.
"uuid": "^11.1.1"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }, | ||
| "overrides": { | ||
| "@typescript-eslint/typescript-estree": { | ||
| "minimatch": "^9.0.7" |
| "minimatch": "^9.0.7" | ||
| }, | ||
| "gaxios": { | ||
| "uuid": "^11.1.1" |
| "@google-cloud/pubsub": "^4.11.0", | ||
| "@grpc/grpc-js": "^1.14.4", | ||
| "pino": "^9.7.0" | ||
| "pino": "^9.14.0" |
| "sinon": "^21.0.0", | ||
| "typescript": "^5.8.3", | ||
| "uuid": "^14.0.1" | ||
| "semantic-release": "^24.2.9", |
Description
Remaining audit findings all trace to the npm CLI bundled in the semantic-release toolchain (release-time only); fixed by the semantic-release@25 major upgrade.
Motivation and Context
Types of changes