Skip to content

Added pull request template & updated changelog#26

Open
harrisonhjones wants to merge 2 commits into
alexa-js:masterfrom
harrisonhjones:pr-template
Open

Added pull request template & updated changelog#26
harrisonhjones wants to merge 2 commits into
alexa-js:masterfrom
harrisonhjones:pr-template

Conversation

@harrisonhjones

@harrisonhjones harrisonhjones commented Jan 19, 2017

Copy link
Copy Markdown

Missing Feature:

Repo is missing a PR template.

New Feature:

PR template added.


Doneness:

  • Be awesome for submitting a PR
  • CONTRIBUTING reviewed
  • Test(s) written to reproduce the problem or missing feature
  • Code written to solve the problem or implement the new feature
  • README updated with documentation (if applicable)
  • CHANGELOG updated with your change
  • Detailed commit messages present

Comment thread CHANGELOG.md Outdated
### Next

* Your contribution here.
* Added pull request template - [@harrisonhjones](https://github.com/harrisonhjones/)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to nitpick on the format. Other lines end with a period :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Let me know if you think anything else needs to be updated.

	- Added period to CHANGELOG entry
	- Link to CONTRIBUTING fixed in template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants