chore(pm): cache projects_v2_node_id to skip per-create gh project view read#424
Merged
Merged
Conversation
…ew read create-issue's board path now reads the project node id from config (projects_v2_node_id) first, live-resolving via gh project view only on a miss. bootstrap populates the field at adoption; adopt-existing resolves + recommends it (it cannot write config per DEC-037 mutate-nothing). Additive optional field, no output change, no migration. Closes #310. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…0 for node-id cache Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Reviewer agent (local, reviewer): APPROVED
Note (informational, not gating): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cache the Projects-v2 project node id in adopter config so
create-issue's board path skips a per-creategh project viewround-trip._resolve_project_node_idreadsconfig["projects_v2_node_id"]first; live-resolves viagh project viewonly on a miss (same id, cached). No output/behaviour change.project/config.yamlat adoption when a board is configured (round-trip write preserves comments; idempotent); no-op in label-fallback mode.--jsoninventory. It does NOT write config, preserving the DEC-037 mutate-nothing invariant (draft-not-apply). The read-side slot in_lib/hooks.pyalready existed; this populates it.Design note
adopt-existingrecommends rather than writes (DEC-037 §1 forbids brownfield config mutation, enforced by tests);bootstrapdoes the write. A faithful reading of "populated at adoption" that respects the stronger invariant.Doc impact
New optional
projects_v2_node_idconfig field documented in the capability README config example (there is no JSON schema for config.yaml).Surface / version
Capability-internal surface change: project-management
component.version0.44.0 -> 0.45.0 (minor). Backbone.pkit/VERSIONunchanged (no dispatcher/COR/manifest change). Additive optional field -> no migration.Verification
gh project viewcalls; cache-miss falls back to live; bootstrap populates when board+uncached, skips otherwise.pkit schemas validatepass;pkit migrations check-diff-> no triggers; exec bits 100755 preserved.Closes #310.