Use weak features in Cargo.toml - #216
Merged
Merged
Conversation
mulimoen
force-pushed
the
feature/weak_features
branch
2 times, most recently
from
May 8, 2022 16:47
2018202 to
c607740
Compare
Owner
|
Rebase on master? |
Owner
|
MSRV fail? |
mulimoen
force-pushed
the
feature/weak_features
branch
5 times, most recently
from
October 18, 2022 05:57
35b6ebc to
5698b17
Compare
Collaborator
Author
|
We will have to bump msrv to use weak features. 1.60 was released 7th April 2022 |
Owner
That's probably ok, simplifies maintenance going forward (whoever needs to use older rustc can always use the current crate version). Probably makes sense to do a few more things:
|
mulimoen
force-pushed
the
feature/weak_features
branch
3 times, most recently
from
October 18, 2022 16:43
dd8a6d9 to
fd323b3
Compare
Collaborator
Author
|
I updated the dependencies listed by |
Collaborator
Author
|
We could start using workspace inheritance as this has been stabilized |
mulimoen
force-pushed
the
feature/weak_features
branch
from
June 9, 2023 17:32
fd323b3 to
a2f88d1
Compare
Collaborator
Author
|
Rebased and cleared for review |
aldanor
reviewed
Jun 10, 2023
aldanor
reviewed
Jun 10, 2023
Owner
|
Probably worth adding an entry to the changelog. (and another entry to Changed if we rename 'deprecated'->'no-deprecated') |
mulimoen
force-pushed
the
feature/weak_features
branch
2 times, most recently
from
June 10, 2023 21:35
417e02d to
9be35ef
Compare
mulimoen
force-pushed
the
feature/weak_features
branch
from
June 10, 2023 21:40
9be35ef to
44b05c1
Compare
Owner
|
Ok, I think it should be good to go - I'll merge it when it's green 👍 |
aldanor
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands on the idea of @ajtribick in #204