Skip to content

Use weak features in Cargo.toml - #216

Merged
aldanor merged 4 commits into
aldanor:masterfrom
mulimoen:feature/weak_features
Jun 10, 2023
Merged

Use weak features in Cargo.toml#216
aldanor merged 4 commits into
aldanor:masterfrom
mulimoen:feature/weak_features

Conversation

@mulimoen

@mulimoen mulimoen commented May 8, 2022

Copy link
Copy Markdown
Collaborator

Expands on the idea of @ajtribick in #204

@mulimoen
mulimoen force-pushed the feature/weak_features branch 2 times, most recently from 2018202 to c607740 Compare May 8, 2022 16:47
@aldanor

aldanor commented Oct 17, 2022

Copy link
Copy Markdown
Owner

Rebase on master?

@aldanor

aldanor commented Oct 17, 2022

Copy link
Copy Markdown
Owner

MSRV fail?

@mulimoen
mulimoen force-pushed the feature/weak_features branch 5 times, most recently from 35b6ebc to 5698b17 Compare October 18, 2022 05:57
@mulimoen

Copy link
Copy Markdown
Collaborator Author

We will have to bump msrv to use weak features. 1.60 was released 7th April 2022

@aldanor

aldanor commented Oct 18, 2022

Copy link
Copy Markdown
Owner

We will have to bump msrv to use weak features. 1.60 was released 7th April 2022

That's probably ok, simplifies maintenance going forward (whoever needs to use older rustc can always use the current crate version).

Probably makes sense to do a few more things:

  • update the README (it mentions MSRV)
  • list it in Cargo.toml of all crates (https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field)
  • bump the edition of all crates to 2021 (and mention it along with MSRV bump in the changelog)
  • perhaps also change if any deps are outdated, idk? (parking_lot, mpi_sys, scopeguard, regex, etc... but maybe it could be a separate pr; lazy_static might even be thrown out in favor of once_cell...)

@mulimoen
mulimoen force-pushed the feature/weak_features branch 3 times, most recently from dd8a6d9 to fd323b3 Compare October 18, 2022 16:43
@mulimoen

Copy link
Copy Markdown
Collaborator Author

I updated the dependencies listed by cargo outdated

@mulimoen

Copy link
Copy Markdown
Collaborator Author

We could start using workspace inheritance as this has been stabilized

@mulimoen
mulimoen force-pushed the feature/weak_features branch from fd323b3 to a2f88d1 Compare June 9, 2023 17:32
@mulimoen

mulimoen commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator Author

Rebased and cleared for review

Comment thread hdf5-sys/build.rs Outdated
Comment thread hdf5-sys/Cargo.toml
@aldanor

aldanor commented Jun 10, 2023

Copy link
Copy Markdown
Owner

Probably worth adding an entry to the changelog.

(and another entry to Changed if we rename 'deprecated'->'no-deprecated')

@mulimoen
mulimoen force-pushed the feature/weak_features branch 2 times, most recently from 417e02d to 9be35ef Compare June 10, 2023 21:35
@mulimoen
mulimoen force-pushed the feature/weak_features branch from 9be35ef to 44b05c1 Compare June 10, 2023 21:40
@aldanor

aldanor commented Jun 10, 2023

Copy link
Copy Markdown
Owner

Ok, I think it should be good to go - I'll merge it when it's green 👍

@aldanor
aldanor merged commit 3f51ffb into aldanor:master Jun 10, 2023
@aldanor
aldanor deleted the feature/weak_features branch June 10, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants