fix(cloudflare): capture framework build output in the test runner - #1114
Open
sam-goodwin wants to merge 2 commits into
Open
fix(cloudflare): capture framework build output in the test runner#1114sam-goodwin wants to merge 2 commits into
sam-goodwin wants to merge 2 commits into
Conversation
Bump cloudflare-tools to alchemy-run/cloudflare-tools#106: the OpenNext build runner now pipes (not fd-inherits) its output so alchemy-test's stray-output capture can divert it, and SvelteKit/Waku/Nuxt vite builds default to logLevel "warn" so rolldown's native fd-writing progress reporter stays out of the terminal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Install the packages built from this commit: alchemy bun add alchemy@https://pkg.ing/alchemy/7b4008f@alchemy.run/better-auth bun add @alchemy.run/better-auth@https://pkg.ing/@alchemy.run/better-auth/7b4008f@alchemy.run/pr-package bun add @alchemy.run/pr-package@https://pkg.ing/@alchemy.run/pr-package/7b4008f |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test runner is supposed to capture all output, but framework builds were printing raw to the terminal during test runs. Two distinct escape paths, both fixed in cloudflare-tools#106 (this PR bumps the submodule + lockfile):
stdout/stderr: "inherit"through Effect'sChildProcessSpawner, whose ESM-boundnode:child_process.spawnbypasses every JS-level patch alchemy-test installs. The runner now pipes and forwards chunks throughprocess.stdout.write/process.stderr.write, which the stray-output capture intercepts (and which still streams to the terminal in a plain deploy).transforming...,✓ N modules transformed.) writes to the fd from Rust — uninterceptable from JS. Their vite builds now default tologLevel: "warn", matching what Astro and Octane already did.Verified against the live cloud:
Nextjs.test.ts,Astro.test.ts+Vite.test.ts, andSvelteKit.test.ts+Waku.test.ts+Nuxt.test.tsall green with zero build output on the terminal; the OpenNext build now appears as[stray stdout]lines in the run log.🤖 Generated with Claude Code