fix(cloudflare): add flagship:write to the OAuth scope catalog - #1032
Draft
aryasaatvik wants to merge 1 commit into
Draft
fix(cloudflare): add flagship:write to the OAuth scope catalog#1032aryasaatvik wants to merge 1 commit into
aryasaatvik wants to merge 1 commit into
Conversation
The scope catalog had no Flagship entry, so OAuth-authenticated profiles could never use Cloudflare.Flagship resources — the first API call fails with a generic Unauthorized. Scope name and description match Cloudflare's shared auth catalog in workers-sdk, where wrangler requests it by default.
Contributor
|
Is there a flahship:read too? Or only write? |
Contributor
Author
|
Only Write is also what the resources need end to end: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OAuth scope catalog has no Flagship entry, so OAuth-authenticated profiles can't use
Cloudflare.Flagship.*resources — the first call fails:Adds
flagship:writetoALL_SCOPESandDEFAULT_SCOPES. Name and description match Cloudflare's own catalog (workers-auth/src/core/scopes.tsin workers-sdk), where wrangler defaults it.Blocked on client registration, verified: Cloudflare's authorize endpoint rejects the scope for alchemy's OAuth client:
So this needs Cloudflare to allowlist
flagship:writeon client6d8c2255-0773-45f6-b376-2914632e6f91first; until then theDEFAULT_SCOPESline would break every login. Draft until that lands — happy to split the catalog-only line out if you'd rather ship it independently.