fix: evita NPE in ItemBuilder.build() con placeholder dal valore null#19
Open
antoilmalvagio wants to merge 1 commit into
Open
fix: evita NPE in ItemBuilder.build() con placeholder dal valore null#19antoilmalvagio wants to merge 1 commit into
antoilmalvagio wants to merge 1 commit into
Conversation
getOrDefault(placeholder, "NULL") protegge solo dalla chiave assente: se il valore mappato è null, value.toString() lanciava NullPointerException. Ora il loop itera su entrySet e sostituisce i valori null con il sentinel "NULL", evitando l'NPE e la doppia lookup key+get. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
ItemBuilder.build()sostituisce i placeholder con:getOrDefaultrestituisce il default"NULL"solo se la chiave è assente. Se la chiave è presente ma il valore mappato ènull(es.addPlaceHolder("%x", possibileNull)),valueènullevalue.toString()lancia un NullPointerException.Riscontrato in produzione da un plugin Novaverse (GUI che passava
OfflinePlayer.getName()null).Fix
Il loop ora itera su
entrySet()e sostituisce i valorinullcon il sentinel"NULL", evitando l'NPE (e la doppia lookup key+get). Comportamento retro-compatibile: un placeholder null ora rende"NULL"invece di crashare.