[16.0][FIX] finish the 16.0 backport: view modifiers and manifest version - #59
Open
almumu wants to merge 1 commit into
Open
[16.0][FIX] finish the 16.0 backport: view modifiers and manifest version#59almumu wants to merge 1 commit into
almumu wants to merge 1 commit into
Conversation
Two leftovers from the backport, both blocking or misleading on 16.0.
1. Four view modifiers still use the Odoo 17+ syntax. In 16.0 a node-level
`invisible` is evaluated against the context only, so an expression that
references a field raises NameError and the module fails to install:
ValueError: <class 'NameError'>: "name 'result_summary' is not defined"
while evaluating 'not result_summary'
The two remaining `invisible="not context.get(...)"` in fr_einvoicing_event.xml
are left untouched: those do resolve against the context in 16.0.
2. l10n_fr_einvoicing_directory_import still declares version 18.0.1.0.0,
while the other nine modules are on 16.0.1.0.0.
Tested on a clean 16.0 community database: the eight installable modules
install without error (81 modules loaded) and the test suite passes
(15 tests, 0 failed, 0 errors).
ak-git-bot
added
mod:l10n_fr_einvoicing
|
Hi @alexis-via, |
almumu
marked this pull request as ready for review
August 20, 2026 09:07
remi-filament
approved these changes
Aug 20, 2026
remi-filament
left a comment
remi-filament
left a comment
Contributor
There was a problem hiding this comment.
Thanks @almumu
Code review looks OK, although I always have a doubt on m2m whether we should check against [] or False (in [('result_partner_ids', '=', [])] )
almumu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the backport, both blocking or misleading on 16.0.
Four view modifiers still use the Odoo 17+ syntax. In 16.0 a node-level
invisibleis evaluated against the context only, so an expression that references a field raises NameError and the module fails to install:ValueError: <class 'NameError'>: "name 'result_summary' is not defined"
while evaluating 'not result_summary'
The two remaining
invisible="not context.get(...)"in fr_einvoicing_event.xml are left untouched: those do resolve against the context in 16.0.Tested on a clean 16.0 community database: the eight installable modules install without error (81 modules loaded) and the test suite passes (15 tests, 0 failed, 0 errors).
Partially addresses #55: this PR covers the two mechanical leftovers (the view modifiers and the manifest version). The third point of that issue — the missing
tests/directory ofl10n_fr_einvoicing_directory_import, 34 tests that exist on the PR #33 branch but not here — is not covered.