fix: carry plugin-created .factory/ subdirs into worktrees - #1265
Draft
shivchander wants to merge 2 commits into
Draft
fix: carry plugin-created .factory/ subdirs into worktrees#1265shivchander wants to merge 2 commits into
shivchander wants to merge 2 commits into
Conversation
Plugin modes registered via add_modes() failed Pydantic validation when headless mode created a CycleState, since the Literal type only accepted hardcoded built-in mode names. Closes #1262 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After the existing symlink/copy logic and per-cycle fresh dirs, iterate over remaining subdirectories in source .factory/ and copy any not already handled. Skips entries already present (symlinked, copied, or created fresh) to avoid duplication. Closes #1263 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sentrux Quality ReportAbsoluteDiff (vs base branch) |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (79.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 86.34% 86.33% -0.01%
==========================================
Files 211 211
Lines 23054 23062 +8
Branches 3627 3631 +4
==========================================
+ Hits 19906 19911 +5
- Misses 2308 2309 +1
- Partials 840 842 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1263
Changes
create_worktree, iterate over any remaining subdirectories in the source.factory/and copy them to the worktreestrategy/reviews/state) via adst.exists()check.factory/buildroot/are the target