You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
voku/html-min released 5.0, but the benchmark suite was pinned to 4.5.1 by a transitive conflict: wyrihaximus/html-compress (another competitor in the suite) is itself a wrapper around voku/html-min, and its latest stable (4.4.0) still requires voku/html-min ^4.5.1. There's only an unmerged dev-renovate/…voku-html-min-5-0-0 branch upstream — no voku-5-compatible release.
Per maintainer decision: drop the wyrihaximus competitor so the suite can benchmark against the current voku 5.0.
wyrihaximus/html-compress is itself a wrapper around voku/html-min and its
latest stable (4.4.0) still pins voku ^4.5.1, which blocks the benchmark
suite from moving to voku 5.0. Since voku 5.0 is the current release we want
to compare against, drop the wyrihaximus competitor and bump voku to ^5.0.
- Remove voku-5-incompatible wyrihaximus/html-compress from the require set,
its VokuAdapter sibling WyrihaximusAdapter, and its test.
- AdapterRegistry now exposes 5 adapters (was 6); registry test updated.
- benchmarks/ is the internal, never-published harness (composer.lock
untracked); no consumer-facing change and no library release implied.
Bench suite green: 41 tests / 111 assertions; rector + cs + phpstan clean.
Regenerated latest.md via `make bench` (clean stamp, SHA a649466) and synced
the README Summary block. Dropped the wyrihaximus row; voku/html-min now
benchmarks at 5.0.0. Also fixed the hand-written competitor list in the
README "Benchmarks" intro (outside the auto-synced block).
This repository is currently using the Sentry GitHub App to receive Codecov PR comments. This integration will be deprecated on July 8, 2026. Please install the Codecov GitHub App to continue receiving coverage reports on your pull requests.
✅ All modified and coverable lines are covered by tests.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR is up to standards according to the quality analysis and correctly implements the core logic changes, including the upgrade of voku/html-min to 5.0 and the removal of the wyrihaximus/html-compress adapter. The registry and test suite have been updated to reflect the new count of 5 adapters.
There is a critical discrepancy regarding documentation. The PR description and acceptance criteria explicitly mention regenerating latest.md and updating the README to reflect the revised competitor list, but these files are not present in the change set. These documentation updates are necessary to maintain consistency between the code and its public documentation.
About this PR
The PR description and acceptance criteria mention updating the README and latest.md files, but these changes are missing from the current diff. Please include these documentation updates to ensure the project documentation reflects the removal of the Wyrihaximus adapter.
Test suggestions
Verify AdapterRegistry::all() returns exactly 5 instances in the expected order
Verify removal of WyrihaximusAdapter implementation and its tests
Confirm voku/html-min is upgraded to version 5.0 in composer.json
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The pull request successfully updates the benchmark suite by removing the wyrihaximus/html-compress package, which was causing a version conflict. This change enables the suite to benchmark voku/html-min version 5.0.0, which was previously pinned to version 4.5.
Codacy results indicate that the changes are up to standards, with no new quality issues or complexity regressions introduced. The adapter registry and its tests have been correctly updated to reflect the removal of the defunct adapter, and documentation has been regenerated to reflect updated performance metrics.
Test suggestions
Verify that AdapterRegistry::all() returns exactly 5 minifier adapters
Verify that the order of adapters in the registry is stable and matches the documentation
Verify that the benchmark run successfully uses voku/html-min version 5.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Why
voku/html-minreleased 5.0, but the benchmark suite was pinned to 4.5.1 by a transitive conflict:wyrihaximus/html-compress(another competitor in the suite) is itself a wrapper aroundvoku/html-min, and its latest stable (4.4.0) still requiresvoku/html-min ^4.5.1. There's only an unmergeddev-renovate/…voku-html-min-5-0-0branch upstream — no voku-5-compatible release.Per maintainer decision: drop the wyrihaximus competitor so the suite can benchmark against the current voku 5.0.
Changes
benchmarks/composer.json: removewyrihaximus/html-compress, bumpvoku/html-min^4.5→^5.0.WyrihaximusAdapter+ its test;AdapterRegistrynow exposes 5 adapters (was 6); registry test updated (assertCount(5), order list).latest.mdviamake bench(clean stamp) and sync the README Summary; fix the hand-written competitor list in the README intro.Verification
make bench-quality: Rector + PHP-CS-Fixer + PHPStan (level max) all clean.make benchcompleted;voku/html-minnow reports 5.0.0 in the regenerated report.benchmarks/is the internal, never-published harness (composer.lockuntracked) — no consumer-facing change and no library release implied.