Fix SSH commit signing: quoting in gpg.ssh.defaultKeyCommand - #26
Open
akan72 wants to merge 1 commit into
Open
Conversation
akan72
force-pushed
the
akan72/fix-ssh-signing
branch
from
August 22, 2026 19:28
1146efc to
dd53a65
Compare
git's config parser consumes the double quotes and \n escapes in the old printf wrapper before the shell sees them, so the wrapper executed the ssh-add output as a command and emitted a bare 'key::' — every commit and tag failed with 'user.signingKey needs to be set for ssh signing'. git only takes the first line of defaultKeyCommand output, so a bare ssh-add -L does the job with no quoting at all. This commit is itself signed via the fixed command.
akan72
force-pushed
the
akan72/fix-ssh-signing
branch
from
August 22, 2026 19:36
dd53a65 to
2087a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpg.ssh.defaultKeyCommand.ssh-add -Ldirectly so Git receives a valid public key.Test Plan
ssh-ed25519public key.git diff --checkand verified the rewritten commit contains a valid SSH signature block.