Fix get_notes silently dropping notes after the first reference-type … - #6
Open
dmarshall-rgb wants to merge 1 commit into
Open
Fix get_notes silently dropping notes after the first reference-type …#6dmarshall-rgb wants to merge 1 commit into
dmarshall-rgb wants to merge 1 commit into
Conversation
…NOTE _get_notes_internal contained a break inside the loop over an entity's NOTE child elements. Once the first reference-type NOTE (a pointer to a separate @n...@ record) was processed, the break exited the loop entirely, silently discarding any additional NOTE tags on that entity -- whether reference-type or inline -- that appeared afterward. Fix: removed the break so the loop continues scanning all NOTE tags on the entity. Verified against Thomas Marshall (@i54@) in a real FTM export, which has two separate NOTE records (a general biographical note and a DAR lineage citation note). Before the fix, only the first note was returned; after the fix, both are returned in full, including correct CONT/CONC reassembly.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a break statement in the _get_notes_internal method of src/gedcom_mcp/gedcom_data_access.py. This change ensures that the loop continues processing all reference-type notes instead of exiting prematurely after the first one, preventing subsequent notes from being silently dropped. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…NOTE
_get_notes_internal contained a break inside the loop over an entity's NOTE child elements. Once the first reference-type NOTE (a pointer to a separate @n...@ record) was processed, the break exited the loop entirely, silently discarding any additional NOTE tags on that entity -- whether reference-type or inline -- that appeared afterward.
Fix: removed the break so the loop continues scanning all NOTE tags on the entity.
Verified against Thomas Marshall (@i54@) in a real FTM export, which has two separate NOTE records (a general biographical note and a DAR lineage citation note). Before the fix, only the first note was returned; after the fix, both are returned in full, including correct CONT/CONC reassembly.