Clarify the MLAT name-privacy label in status output#146
Merged
Conversation
The 'running (name: public)' suffix read as if the feed name were literally 'public'. It renders the MLAT_PRIVATE posture (whether the name is public or private), so reword to '(public name)' / '(private name)'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MLAT service line in
apl-feed statusappended(name: public)/(name: private), which reads as if the feeder's MLAT name were literally "public" or "private". The suffix actually reflects whether the name is shown publicly on the MLAT map. Reword it to(public name)/(private name)so the line reads naturally.