Document why --max-range appears twice on image installs#145
Merged
Conversation
JSON_OPTIONS and FEED_IMAGE_OPTIONS both default --max-range 450, so a new-image cmdline carries it twice. The overlap is load-bearing across install populations (legacy /boot env lacks the cap; standalone lacks FEED_IMAGE_OPTIONS), so document it instead of deduping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a new-image feeder the daemon cmdline carries
--max-range 450twice — once fromJSON_OPTIONSand once fromFEED_IMAGE_OPTIONS— which reads like a copy-paste bug. It is not: legacy images ship their ownJSON_OPTIONSvia/boot/airplanes-envwithout a range cap (so theFEED_IMAGE_OPTIONScopy is the only cap there), while standalone installs get it only fromJSON_OPTIONS. readsb takes the last occurrence and both are the same value. Add a comment so the overlap does not get "cleaned up" and silently drop the cap for one population.