Fix restore failing on a piped backup#141
Merged
Merged
Conversation
restore documented `/dev/stdin` as a valid source, but the `[[ -f ]]` guard is true only for regular files, so a piped payload died with a misleading "does not exist". Even past that, read_backup_file reopens its argument once per field, which a single-read pipe cannot satisfy. Materialise a non-seekable source into a bounded temp file before parsing; regular-file paths keep their existing existence check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a feeder backup that is piped into
apl-feed restore /dev/stdinfailed with a misleading "does not exist" error. The source check only accepted regular files, so a pipe was rejected outright; and even past that, the parser reopens its input once per field, which a single-read pipe cannot satisfy.A non-seekable source is now buffered into a bounded temporary file before parsing, so a piped backup restores correctly. Restores from a regular file path are unchanged and a genuinely missing path still reports that it does not exist.