Conversation
1. Adds a test suite for the replayer component, distributed in three files: * **replay_test.cpp**: Validates the ReplayImpl logic, including time advancement, play/pause/stop state transitions, seeking within indexed archives, and the correct sequential application of keyframes and payloads over time. * **replayed_object_test.cpp**: Verifies the correct restoration of ReplayedObjects from snapshots, ensuring injected changes are only reflected after flush/commit. It guarantees immutability by throwing exceptions on mutable operations and validates proper serialization and property getter resolution. * **replayer_test.cpp**: Tests the ReplayerImpl orchestration, confirming robust error handling when opening invalid or duplicate archives, and verifying proper session management when closing active recordings. 2. It centralizes test utilities by migrating them to archive_test_helpers.h, establishing common functions for temporary directory management, timestamps, and archive setup. 3. Resolves some bugfixes in: * **components/replayer/replay.cpp**: seeking to an intermediate time, only loaded the closest keyframe, ignoring subsequent events. Now calculates the time difference and processes incremental events up to the exact taget time. * **libs/db/input.cpp**: handle an empty keyframe & handle the out of range search resolves SEN-1479
… move implementation checks to the test file resolves SEN-1635
…comment lines and commas after the last field resolves SEN-1645
Object naming convention added to sen documentation resolves SEN-1553
…r and the python REST client Improve the documentation for the web explorer and REST Python client app examples with usage guides. resolves SEN-1530
…l handler Add query param to the object retrieval handler to include property values resolves SEN-1593
Reported discrepancies between implementation and specification. resolves SEN-1590
resolves SEN-1646
BREAKING CHANGE: Targets will now be generated in the defined directories if global CMake output directories are set. Projects that have these directories defined, but still hardcode paths assuming that Sen targets will be placed in `${PROJECT_BINARY_DIR}/bin` or `lib`, will break. Users must update their build systems to reference the appropriate CMake variables instead of hardcoded paths.
resolves SEN-1654
…w cmake function to generate interface only packages * Adds mapping files as target property for fom targets * Adds two cmake functions to generate interface only packages resolves SEN-1615 resolves SEN-1614
…eration BREAKING CHANGE: Generated C++ structs for optional parameters will now use MaybeXX instead of the base type. Code relying on direct field access will fail to compile. Users must update their code to handle these fields by checking their existence before accessing the underlying value; and by constructing the MaybeXX type explicitly when assigning values. resolves SEN-1644
* compile error on linux systems missing default environ * remove unnecessary system dependenct linux headers resolves SEN-1662
resolves SEN-1628
Get object definition endpoint returned all setters, also including the related to not writable properties. It was also not returning the definition endpoints for getters. resolves SEN-1591
resolves SEN-1688
First suit of integration tests that runs in a containerized manner. It tests object detection and update correctness between a set of local/remote participants. resolves SEN-1523
resolves SEN-1688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.