This repository was archived by the owner on Oct 9, 2023. It is now read-only.
escape closing tags#167
Open
jburghardt wants to merge 5 commits into
Open
Conversation
ljharb
approved these changes
Oct 11, 2019
Collaborator
|
It'd be good to add a test specifically for the newline case, if we can. |
Author
|
Thought about that too, I'll add something by monday |
Author
|
it should now correctly check that 'loads the escaped content correctly' also checks the json.parse method, which failes without |
Author
|
review was requested btw |
…, `rimraf`, `safe-publish-latest`
Collaborator
|
This is ready to go, but tests are failing for an unrelated reason. I'm looking into it. |
Closed
ljharb
force-pushed
the
master
branch
5 times, most recently
from
25e6e39 to
27cd82a
Compare
|
Hey @ljharb - any luck getting the aforementioned tests to pass? Happy to help if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escapes closing tags
Fixes #165.