test(settings-store): inventory deferred load facade locals

[ewen-poch]

Problem

perf(startup): defer transcript and runtime probes (#1637) changed settings-store load() so the persisted Settings snapshot can publish before runtime probes finish. The architecture inventory still expected the previous combined Promise.all binding and a single catch (error).

That guard only runs in the full portable suite (Full Module tests (macOS)), not in test:module, so later PRs fail PR Gate even when they do not touch Settings.

Observed on PRs including #1641, #1643, #1648, #1524, and #1432:

shouldInitializeRuntime is new facade state
settingsPromise is new facade state
runtimeInitialization is new facade state
snapshot is new facade state
[preflight, encryptionAvailable, npmAvailable] is new facade state
[snapshot, preflight, encryptionAvailable, npmAvailable] declared 0 times
error declared 2 times

Proposed change

Update the facade variable inventory to the current load() locals and allow the two catch (error) bindings. Production load behavior is unchanged.

Scope and non-goals

• In scope: settings-store.architecture.test.ts inventory only.
• Out of scope: original feature PRs, Settings load behavior, module-impact routing.
• This does not fix PR-specific failures such as feat(settings): collapse scenario model routing into an accordion card #1645 (PR policy / E2E / other unit tests) or feat(files): add editable artifact versions #1204 (CI Integrity).

Acceptance criteria and validation

• Architecture inventory matches the deferred-load load() locals.
• New undeclared facade bindings are still rejected.
• After the last material edit:
  • npm test -- src/renderer/src/stores/settings-store.architecture.test.ts src/renderer/src/stores/settings-store.test.ts → pass
  • npx vitest run --project architecture → 28 files / 221 tests pass
  • npx eslint src/renderer/src/stores/settings-store.architecture.test.ts → pass

Review focus

Confirm the inventoried names are load-local control flow from #1637, not new feature actions or Settings writes on the facade.

Historical compatibility

None. No schema, Session JSON, or on-disk format change.

New enum / state values

None.

Persistence

None.

[github-actions]

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defects in the pull request changes. The architecture test inventory matches the current Settings facade declarations.