Remove legacy FTL extract and stub helpers#51
Open
andrew000 wants to merge 2 commits into
Open
Conversation
- drop obsolete extract and multiple_extract CLI modules - remove Fluent stub wiring from the stub command - keep stub generation limited to gettext catalogs - refresh README with installation, backend, CLI, and FTL-Extract guidance BREAKING CHANGE: FTL extraction and FTL stub generation are removed from aiogram_i18n. Use FTL-Extract for FTL workflows.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy Fluent (FTL) extraction and stub-generation helpers from aiogram_i18n, keeps the i18n stub CLI command focused on GNU gettext catalogs, and refreshes the README to reflect the new guidance (FTL workflows moved to FTL-Extract).
Changes:
- Removed deprecated Fluent extraction CLI modules and the Fluent stub helper.
- Updated
i18n stubto support only.mo,.po, and.potinputs and adjusted CLI behavior accordingly. - Rewrote the README with updated installation/backends/CLI documentation and FTL-Extract guidance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/aiogram_i18n/utils/fluent_stub/__init__.py |
Removes the legacy Fluent stub helper module. |
src/aiogram_i18n/utils/cli/stub.py |
Drops .ftl support and adjusts stub command behavior to gettext inputs only. |
src/aiogram_i18n/utils/cli/multiple_extract.py |
Removes the legacy “multiple extract” Fluent CLI module. |
src/aiogram_i18n/utils/cli/extract.py |
Removes the legacy Fluent extract CLI module. |
src/aiogram_i18n/utils/cli/__init__.py |
Stops exporting/registering the removed extract commands. |
README.md |
Updates documentation and guidance, including directing FTL workflows to FTL-Extract. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- reject mixed gettext catalog input extensions - use Click exceptions for CLI validation errors - point the README license badge at the package page
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/aiogram_i18n/utils/cli/stub.py:40
- The validation error "only files allowed" is too vague for CLI users (it doesn't indicate which path failed or that the path must exist and be a file). Consider including the invalid path and a clearer description (e.g., "input path must be an existing file").
if not path.is_file():
msg = "only files allowed"
raise click.ClickException(msg)
Contributor
Author
|
@RootShinobi review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ftlsupport fromi18n stub.i18n stubfocused on gettext inputs:.po,.pot, and.mo.Breaking Change
FTL extraction and FTL stub generation are no longer provided by
aiogram_i18n.Use
FTL-Extractfor those workflows instead.Testing
just lint