This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Remove redundant TimeoutError class#1444
Open
farahats9 wants to merge 4 commits intoaio-libs-abandoned:masterfrom
Open
Remove redundant TimeoutError class#1444farahats9 wants to merge 4 commits intoaio-libs-abandoned:masterfrom
farahats9 wants to merge 4 commits intoaio-libs-abandoned:masterfrom
Conversation
|
This pull request introduces 1 alert when merging 3ad900b into 19be499 - view on LGTM.com new alerts:
|
Rooba
approved these changes
Nov 13, 2022
Rooba
left a comment
There was a problem hiding this comment.
considering __builtins__ is already going to be present, the import for builtins poses no difference.
Rooba
approved these changes
Nov 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Remove the
builtins.TimeoutErrorclass from base classes ofaioredis.exceptions.TimeoutErrorbecause it is causing an error due to its redundancy.Are there changes in behavior for the user?
No
Related issue number
#1443
Checklist
CONTRIBUTORS.txt<Name> <Surname>.CHANGES/folder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.