Review: Rotten Tomatoes source data, environment and task verification (original #26) - #87
Draft
jackjin1997 wants to merge 5 commits into
Draft
Review: Rotten Tomatoes source data, environment and task verification (original #26)#87jackjin1997 wants to merge 5 commits into
jackjin1997 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reviewer continuation builds on @derenlei's original #26 and preserves the original commits and movie identities.
It replaces unsupported catalog facts and media with a source-recorded 147-movie snapshot, repairs account/form/persistence behavior and responsive presentation, integrates the site at port 40019, and supplies grading contracts for seven quality-selected tasks. The original four demo accounts, watchlists and personal ratings are preserved.
The review report contains source coverage, unedited upstream/before/candidate screenshots, known limitations, and reproduction commands. Validation so far: 35 application tests and 59 portable verifier unittest methods passed. These tests accompany the change; constructed scoring fixtures are explicitly separate from real browser runs.
Assets: HF PR #55, pinned to
68798983027ceaf17df62f6167625baae38a160a. The 777,480,887-byte archive's remote SHA-256 matches67d7206031d284e268d9f5887693ebe8059555a671a604efb22c51a5fae6934d. The asset PR is still open; its immutable revision is a review candidate.Draft — not ready for approval. The full-image attempt failed when local Docker storage became read-only after disk exhaustion. Recovery, the complete 20-site health/reset checks, independent runs of the seven revised tasks, human visual acceptance, and independent blind review remain outstanding. A guided registration pilot completed its UI operation but correctly failed grading after an observation timeout left missing evidence; that failed run has not been repaired or counted as a success.
After those checks and any resulting corrections, this PR will be updated for maintainer review. Maintainers coordinate the final GitHub/HF merges and asset pin.