Skip to content

Review: Compass environment, source-backed data and task verification - #84

Open
jackjin1997 wants to merge 28 commits into
aiming-lab:mainfrom
jackjin1997:review/pr-25-compass
Open

Review: Compass environment, source-backed data and task verification#84
jackjin1997 wants to merge 28 commits into
aiming-lab:mainfrom
jackjin1997:review/pr-25-compass

Conversation

@jackjin1997

@jackjin1997 jackjin1997 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Reviewer takeover of original #25, contributed by sarendis56 (Peichun Hua). Original commits and attribution are retained.

Human experience and disclosed scope accepted; Ready for maintainer review at the owner's request. The original 16-task independent review is complete and reconciled. The refreshed task17 independent verdict remains outstanding and is not counted as PASS. Maintainer handoff, exact versions and remaining actions.

Changes

  • Removes generated listing facts, repairs local state/ownership/input handling, and aligns 16 source-backed task/rubric/verifier contracts. Unsupported original tasks8/9 are retired without renumbering.
  • Repairs homepage/navigation, Concierge and the directory. Sell now has 13 source-derived sections, 3-card and 6-state carousels, and two local inquiry forms. 24 regional landings with 401 community cards restore original images/order, responsive layout and stacked nearby-home groups.
  • Individual community articles and nearby searches remain explicit external links. Films use local posters and external video links; inquiries stay local. Benchmark answer isolation is preserved.

36 source / before / after and interaction captures · Earlier homepage/navigation52 captures · Concierge/directory26 captures

Original NYC regional page Before After
Original Before After

Candidate and validation

Application 7f6dc008603182c6ace79ad52e52f2f8b804ae4b; documentation 2579570e11e8d8220232187d7b02bd3a52a80472; integration base 90afddb6d4af382935ded9a385f2eead604188cf. Registry: 20 sites, Compass 40019, control8101.

  • 178 tests PASS:54 application/source and124 verifier cases. Real UI inquiry, refresh without duplicate write, Compass reset 0.75s, reset-all 2.58s, 23/23 seed files equal.
  • 20/20 homepages and 470 local route/media URLs200. Final prepared image and QA/owner runtime match 455 payload files. This status-only transition rechecked current runtime, all20 homepages, published screenshot hashes and frozen evidence. Existing same-version build/reset/test evidence is reused; no new clean build of all sites is claimed.
  • HF assets PR53, OPEN/no conflicts, immutable revision d86ec0bfcbb98f92efbe6b6b4440f9dcc6cceb69. Archive 210,301,426 bytes, SHA256 077cfb2334cb40bf191b2e557c0becd6e28a1901e7ea80183216c1e9db1544aa;442 added public media,2467 prior files unchanged, additive seed preserving all9 original table rowsets. Other19 archives unchanged.
  • Environment/source/task/verifier audit and reconciliation:16 retained guided runs/268 screenshots,16 deterministic PASS and16 independent PASS. The original Claude review visually sampled four screenshots; it is not certification of subsequent UI changes. The refreshed task17 packet has8 steps/16 screenshots and39 immutable inputs; its independent verdict is pending. All932 original execution files and39 refreshed inputs were rehashed unchanged.

Transition checks · Detailed UI/asset/reset evidence · Reproduce.

Ready means open for maintainer review, not immediate merge approval. Remaining: resolve the refreshed task17 review coverage, coordinate HF merge/final asset pin, and perform maintainer integration/code review. Maintainers merge both PRs.

sarendis56 and others added 14 commits May 16, 2026 11:26
Adds a Flask mirror of compass.com as the 16th WebHarbor site, with
browse / search / filter, listing detail, agent directory, account
flows (save, tour, inquiry, saved search, collection), and 18
WebVoyager-format benchmark tasks.

sites/compass/:
- app.py (1011 lines): 10 SQLAlchemy models, 35+ routes,
  token-overlap scored search with city/state/neighborhood boosts.
  User.check_password accepts both pbkdf2 and bcrypt prefixes so
  seed-time PBKDF2 hashes (deterministic) coexist with runtime
  Flask-Bcrypt writes.
- seed_data.py (659 lines): idempotent function-level gates;
  PBKDF2 with fixed per-email salt to preserve byte-identical reset;
  Co-op pool backfilled to keep filter-based tasks at >=5 candidates.
- 33 Jinja templates + 327-line hand-rolled CSS (white/black/serif
  to match the real Compass palette).
- tasks.jsonl: 18 WebVoyager tasks (3 hard multi-step).
- listings_clean.json: 524 normalized listings consumed by seed_data
  at build time (committed alongside the mirror, per the convention
  used by booking/, arxiv/, etc.).

Registration (3 files, must stay in sync per AGENTS.md):
- websyn_start.sh: compass appended to SITES, two ready-count 15s -> 16.
- control_server.py: 'compass' appended to SITES.
- Dockerfile: EXPOSE 8101 40000-40015.

Heavy assets (instance_seed/compass.db, static/images/, ~129 MB
packed) ship via the companion HuggingFace PR
ChilleD/WebHarbor#3. .assets-revision already pins main, so once
that merges this Just Works.

Byte-identical reset verified:
  md5sum instance/compass.db instance_seed/compass.db
  -> 2a7458e3b6c3e3d0b39c32cca5d0f519 (both files).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jackjin1997

Copy link
Copy Markdown
Contributor Author

Independent blind first-pass review (Compass, 16 tasks)

Reviewer model: Claude Fable 5.1 (claude-fable-5-1), first pass restricted to the frozen execution packet. No verifier code/results, expected answers, PR contents, source, or live DB were read before this verdict was frozen.

Scope

  • Reviewed code: b66016dd16dfc7eb776f58d5490fc31caecac68c (current PR head at posting time). Image code actually run: 3cdc0b66d72b8a789b89583176c668081de36852 (wh-review025:3cdc0b6).
  • HF asset revision: 47232eba972567d138bbac478a6f4af9775a1d90.
  • Input manifest SHA-256: 3125bf726ae7e8faa3020c070d5f08037b619f0474ab3c2c552a272e25be41fd (618 listed files, all sizes/hashes verified, no extra files).
  • Frozen verdict SHA-256: 342633f8e1a3f0a31cf5983912c196573a4c7336591d66d3c315938f1035f662.
  • Executor: Codex GPT-6, guided/source-aware run. These are judgments of whether those runs completed the tasks, not a measure of independent exploration capability.

Result: 16/16 PASS, 0 FAIL (Compass--0 to 7, 10 to 17). No failed task IDs.

Method

  • Every before.db equals the runtime seed; all SQLite read read-only.
  • Each read-only task's target was recomputed independently from the seed DB using unrounded price/area ratios and compared against the final answer and the property-details DOM.
  • Row-level diff of all tables before/after for every task: write tasks (4, 5, 6, 7, 10, 14, 15) changed exactly the requested rows and nothing else; read tasks left the DB byte-identical to the seed. The new account's password hash was bcrypt-verified.
  • Trajectories and DOM observations checked for genuine local UI evidence on the decisive pages (details, Saved Homes, Tours, collection and share page, Saved Searches reopen, Inquiries); 4 screenshots sampled visually.
  • Compass--3 contains one retained failed link lookup (selector without the "Pending" badge prefix), recovered on the next step; not counted against the task.

Interpretive assumption worth cross-checking: listings with status = for-sale and a "Pending" badge were treated as for-sale eligible, matching the snapshot status field and the app's own "For sale" filter. This affects the selections in Compass--3, --11 and --17; if pending homes are meant to be excluded, those three would need re-evaluation. " search area" was mapped to market_city; using city gives identical results.

Not performed / not certified

  • Did not re-run the app or image; did not verify harness, archive or image hashes, or raw JPEG-to-PNG fidelity.
  • Only 4 of 258 screenshots inspected visually; the rest relied on complete DOM observations.
  • Compass--15 message body verified from the after DB only (the inquiries list shows subject, not message).
  • Human experience, upstream source fidelity, visual quality and verifier implementation are out of scope and not certified by this review.

Structured per-task rationale and evidence are in the frozen verdict file held by the reviewer.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Independent-review reconciliation

Rechecked the frozen verdict hash and all 618 input-file hashes. All 16 task verdicts agree with deterministic scoring. The original Claude verdict remains unchanged.

  • Pending: the existing local For sale filter includes Pending / Contract Signed sale listings; their source status is preserved in property details. Tasks 3, 11 and 17 do not ask for active-only listings. Recomputing their selections supports the recorded PASS results.
  • Search area correction: city and market_city are not interchangeable for New York. Literal city='New York' yields no qualifying Co-ops; the actual UI search area (city OR market_city) includes seven, including Brooklyn/Manhattan addresses. Rechecking that query preserves task 3's target and PASS.
  • Screenshot correction: the immutable manifest contains 268, not 258, screenshots. Claude visually sampled four; the review does not establish comprehensive visual acceptance.
  • Task 15: independently confirmed exactly one inquiry with the requested subject/message and correct user/listing/agent, with all other tables unchanged. The task requires persistence, not a subsequent message-body display.

Updated report and evidence boundaries. This follow-up changes documentation only and reuses the frozen review candidate b66016dd16dfc7eb776f58d5490fc31caecac68c. Human experience remains pending; the PR stays Draft.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Addressed the human-reported missing Sell section in e55721b5eb9bd814910dcb3895a665558d730276 (application checkpoint a5e25af): desktop/mobile navigation and the homepage entry now reach /sell/ instead of a missing page. The local introduction uses the original hero image and measured desktop/mobile typography/layout; its contact CTA opens the existing agent directory. The source seller lead form and full seller-service workflow are not implemented.

Four original / before / after comparison groups and remaining differences · Checks and image/input hashes

Sell, 1440×900 Original Before After
Actual browser capture Original Before After

Validation: 42 application/source tests pass, existing Buy/Rent and login/navigation work in the real browser, all 20 homepages return 200, and Compass reset is byte-identical. The incremental Docker build and owner runtime have the same six changed file hashes; updating the owner environment preserved its database and left the other 19 processes untouched.

HF #53 now pins 421ca6a529b88bdd214ecf6308d124798ab1e20b: one added Sell image, all 2,412 previous archive files including seed unchanged, other 19 site archives unchanged. The PR body/report distinguish this update from the frozen task runs and Claude verdict. Task/rubric/verifier inputs are unchanged; original task evidence is reused by impact with fresh shared-entry checks. Claude has not reviewed the new Sell page. Human experience is still pending; this PR remains Draft.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Homepage/navigation correction pushed in 9741284 (evidence/report 5859a3c). The earlier Sell-only patch left substantial structure missing. Original / before / after comparisons, scope limits and validation now cover the desktop/mobile homepage, all dropdown groups, drawer, services, community banners and footer; 32 verified viewport screenshots are included.

Current checks: 168 tests PASS, 91 local homepage URLs/assets, 20/20 site homepages, matching 29-file incremental image, and byte-identical Compass reset. Compass--17 was newly recorded at the final application commit: 8 steps / 16 screenshots, deterministic PASS and unchanged DB. Its refreshed independent review is pending; the older 16-task review is not relabeled as coverage of this UI.

HF #53 now pins e06307429dca76a8a7240d507ab69be9e5b84060 (16 source media added; all 2,413 prior files and 19 other archives unchanged). PR remains Draft for human visual acceptance, confirmation of the disclosed deep-page limits, and the refreshed independent verdict.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Follow-up: the actual 815px viewport exposed remaining structural defects in 9741284. Commit 82b5915 fixes the tablet hero, two-column cards/promotion and neighborhood layout, stacked Concierge source imagery, directory folding and footer columns.

The updated source/before/after report adds 20 verified viewport images (52 retained total), final responsive and runtime checks, asset pin 5b66b75, and explicit evidence-reuse scope. The existing frozen task 17 execution stays bound to 9741284; it was not relabeled or overwritten. Human acceptance and its independent verdict remain pending; this PR remains Draft.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Concierge and Neighborhood Guides reconstruction is now in 25b8b3375aeb5a3b2c5823f8ed6d52a05eddeccf (report fd30342795f477165adb3c794a5e8cbe5205a3f2). The former one-panel Concierge and six-tile directory now use source-derived structure, original media and responsive layouts, including all eight Concierge case states and 24 directory regions.

26 source / before / after screenshots, measured sections and remaining boundaries · Validation and hashes

Validation: 168 tests passed during the repair; final browser checks exercise the case controls and local CTA. The final incremental image matches 47 runtime files; all 20 homepages and 69 local routes/media URLs return 200, and Compass reset restores the seed byte-for-byte. HF #53 now pins b09ad95ac9428d5f98e1dc6206f1fa5f87aec671 with 38 added public assets; all previous asset bytes and seed are preserved.

Human visual/scope acceptance and the refreshed Compass--17 independent verdict remain pending. Existing frozen executions keep their original versions; these new page captures are UI QA evidence. PR remains Draft.

@jackjin1997

Copy link
Copy Markdown
Contributor Author

Sell and regional-guide reconstruction is now in 7f6dc008603182c6ace79ad52e52f2f8b804ae4b (report 4a80f3819f0c3b443a11663c5ec79a8862c3a234). The previous short Sell page and regional property-list substitutes were material fidelity gaps. The candidate now includes13Sell sections,3/6-state carousels, local inquiry persistence, and24source-derived regional landings with401community cards. A final source comparison also corrected the nearby-home groups from three columns to the original stacked layout.

36 source / before / after and interaction captures, measured geometry, validation and explicit scope limits.

178testsPASS;20homepages+470localURLs200; realUI inquiry/reset and23/23reset-all seed equality. Final455payload hashes match the prepared image and owner runtime; original benchmark rows are preserved. HF53 now pins d86ec0bfcbb98f92efbe6b6b4440f9dcc6cceb69 with442publicmedia additions and an additive seed migration; other19archives are unchanged.

Frozen task trajectories and the earlier Claude verdict retain their original identities. Human visual/scope acceptance and the refreshed task17 independent verdict remain pending. PR stays Draft.

@jackjin1997
jackjin1997 marked this pull request as ready for review September 7, 2026 14:37
@jackjin1997

Copy link
Copy Markdown
Contributor Author

Marked Ready for maintainer review at the owner's explicit request, following acceptance of the current human experience and disclosed scope. Documentation-only handoff: 2579570e11e8d8220232187d7b02bd3a52a80472; application and HF assets remain 7f6dc00 / d86ec0b.

Maintainer handoff and remaining actions · Fresh transition checks.

Rechecked current455-file runtime payload,20 site homepages,16 grading contracts,932 original execution files,39 refreshed task17 inputs and36 public image hashes. The existing178-test and realUI/reset evidence applies unchanged. HF53 is reachable, open and conflict-free; all archive hashes match.

The original16-task independent result is complete and reconciled. The refreshed task17 independent verdict has not returned and is not marked PASS. It remains disclosed for resolution alongside HF merge/pin coordination and final maintainer review. No GitHub or HF merge was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants