Add envelope widening fixture (#74) - #75
Merged
Merged
Conversation
Keep malformed-envelope construction inside deploy-core so dependent metadata tests do not duplicate the private footer layout. The compact fixture can be written sparsely while bounded readers reject it before an allocation. Closes #74
Reject widened envelopes whose total extent cannot fit the container format, and document the feature's expanded test-only surface. Part of #74
Contributor
Author
|
[Reviewer Round 1] Approved — no blocking findings. The fixture at src/payload.rs keeps the footer layout private, is correctly feature-gated, and constructs the compact prefix/footer form needed for sparse writing. Its tests exercise both bounded non-reading and unbounded envelope access, while the integration test verifies dependent-style public use. PR #75 correctly uses |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
Contributor
Author
Suggested squash commitTitle Body |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-supportpayload fixture that rewrites envelope lengths while retaining the private footer layout.Closes #74
Test plan
test-supportenabled.cargo build,cargo fmt -- --check --config group_imports=StdExternalCrate, both required Clippy configurations, both test configurations, andRUSTDOCFLAGS='-D warnings' cargo doc --no-deps.