Expose bounded manifest parsing (#72) - #73
Merged
Merged
Conversation
Keep the bounded reader as the only source access while making metadata available to callers without trust material. Centralizing its error mapping preserves the existing container API contract. Closes #72
Contributor
Author
|
[Reviewer Round 1] Approved — no findings. The new public method correctly reuses the retained manifest/footer state and exactly preserves Documentation clearly marks the result unauthenticated and directs TrustSet users to authenticate before parsing. Tests cover external-crate access for signed and unsigned containers, both error categories, refused envelope blocks, and no additional reads/seeks. The PR body properly closes #72 and includes a test plan; the thread contains no stray issue creation. |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnparsedContainer::parse_unverified_manifestso callers can decode metadata fromread_package_containerwithout reopening the source or providing trust material.open's manifest error mapping.TrustSet.Closes #72
Test plan
read_package_containerproduce the same manifest asopen, without aTrustSet.PayloadError::ManifestParseand an unsupported manifest format maps toPayloadError::InvalidManifest.cargo build,cargo fmt -- --check --config group_imports=StdExternalCrate, both required clippy configurations, both required test configurations, andRUSTDOCFLAGS=-D warnings cargo doc --no-deps.