Skip to content

Add unsigned writer compatibility fixture (#68) - #71

Merged
sehkone merged 1 commit into
mainfrom
sehkone/issue-68
Aug 26, 2026
Merged

Add unsigned writer compatibility fixture (#68)#71
sehkone merged 1 commit into
mainfrom
sehkone/issue-68

Conversation

@sehkone

@sehkone sehkone commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add pre-signing manifest and decoded archive compatibility fixtures for the fixed unsigned-writer input.
  • Replace the self-comparison regression test with a public append_trailer test that checks the base, manifest, decoded archive, and stable footer fields.
  • Keep compressed archive bytes and the compressor-dependent footer length out of the golden assertions.

Closes #68

Part of #66

Test plan

  • Perturb the tar mtime and manifest field order separately; each fixture comparison fails with the affected block named.

  • Run cargo test unsigned_writer_matches_pre_signing_block_fixtures to compare the public writer output with both fixtures.

  • Run cargo fmt -- --check --config group_imports=StdExternalCrate.

  • Run cargo clippy --all-targets -- -D warnings.

  • Run cargo clippy --all-targets --features test-support -- -D warnings.

  • Run cargo test.

  • Run cargo test --features test-support.

Pins the public unsigned writer to pre-signing manifest and tar bytes while leaving compressor output unpinned.

Closes #68
@sehkone

sehkone commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

[Reviewer Round 1]

Approved — no findings.

The new test drives public append_trailer, pins manifest and decoded tar bytes to checked-in fixtures, and asserts the stable footer/base layout without goldening compressor-dependent data. It replaces the former self-comparison and satisfies the issue’s compatibility intent. PR linkage and test plan are also correct.

@sehkone

sehkone commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

[Review Verdict Round 1: APPROVED]

@sehkone
sehkone merged commit f45bf79 into main Aug 26, 2026
4 checks passed
@sehkone
sehkone deleted the sehkone/issue-68 branch August 26, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unsigned writer compatibility fixture

1 participant