Add unsigned writer compatibility fixture (#68) - #71
Merged
Conversation
Pins the public unsigned writer to pre-signing manifest and tar bytes while leaving compressor output unpinned. Closes #68
Contributor
Author
|
[Reviewer Round 1] Approved — no findings. The new test drives public |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
append_trailertest that checks the base, manifest, decoded archive, and stable footer fields.Closes #68
Part of #66
Test plan
Perturb the tar
mtimeand manifest field order separately; each fixture comparison fails with the affected block named.Run
cargo test unsigned_writer_matches_pre_signing_block_fixturesto compare the public writer output with both fixtures.Run
cargo fmt -- --check --config group_imports=StdExternalCrate.Run
cargo clippy --all-targets -- -D warnings.Run
cargo clippy --all-targets --features test-support -- -D warnings.Run
cargo test.Run
cargo test --features test-support.