Expose bounded envelope read (#69) - #70
Merged
Merged
Conversation
Allow metadata consumers to inspect untrusted package envelopes without allocating footer-sized blocks, while keeping the verifier and reader on the same bounded implementation. Closes #69
Exercise the bounded metadata path against a real sparse file and mark the new accessors must-use so a caller does not silently discard the reported envelope state.
Contributor
Author
|
[Reviewer Round 1] Approved — no findings. The PR exposes the existing bounded path without duplicating it: It also documents all four specified unbounded readers, publishes the verifier’s actual constants, and includes both an external-consumer integration test and the requested real sparse-file regression coverage. PR #70’s issue linkage and test plan are in order; there are no review-thread hygiene concerns. |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
Contributor
Author
Suggested squash commitTitle Body |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #69
Test plan