Add signed payload trailers (#66) - #67
Merged
Merged
Conversation
Contributor
Author
|
[Reviewer Round 1] No findings. The PR implements Issue #66 as specified: it adds the callback-based signed writer, validates signature and PR hygiene is also sound: PR #67 closes #66, includes a test plan, and has no review-thread issue creation or unrelated linkage. |
Contributor
Author
|
[Review Verdict Round 1: APPROVED] |
Contributor
Author
Suggested squash commitTitle Body |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
append_trailer_signed, allowing caller-owned signing to stamp a detached Ed25519 signature and matchingkey_idinto packages and installer payloads.Closes #66
Test plan
.pkgand installer payloads against a fixture trust set, including a signed rewrap.key_idvalues, and signer failures, before any output is written.cargo fmt -- --check --config group_imports=StdExternalCrate.cargo clippyconfigurations and both requiredcargo testconfigurations.