feat(vllm-omni): preserve generated video audio - #13707
Draft
furionw wants to merge 1 commit into
Draft
Conversation
furionw
force-pushed
the
qiwa/omni-video-audio-output
branch
from
August 24, 2026 03:29
6aff7de to
0e3911f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #13706.
Why
Joint audio-video diffusion models return video frames as the primary output and audio plus media rates as multimodal metadata. Dynamo currently reads only the frames and re-encodes a silent VP9 MP4, losing a model-generated modality. The formatter should preserve every generated video, mux synchronized audio when present, and leave the existing royalty-free silent-video path unchanged.
What Change
classDiagram DiffusionFormatter ..> MediaMuxer : muxes joint outputs DiffusionFormatter ..> VideoData : records actual media metadata DiffusionFormatter --> MediaStorage : uploads completed MP4 bytes note for DiffusionFormatter "Normalizes, pairs, encodes, and formats diffusion outputs"Test Plan