fix(http): bound remote media downloads - #13705
Draft
furionw wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dynamo fetches user-supplied remote media through shared HTTP clients, but response size was only known after buffering the complete body. Large or unbounded responses could therefore consume arbitrary memory before callers rejected them. Enforcing an optional limit inside both streaming clients keeps existing uncapped callers unchanged while giving media paths a reliable resource boundary, including across redirects.
What Change
classDiagram HttpClient <|-- AiohttpClient HttpClient <|-- HttpxClient AiohttpClient ..> HttpBodyTooLargeError : rejects oversized streams HttpxClient ..> HttpBodyTooLargeError : rejects oversized streams note for HttpClient "Defines the optional max-bytes contract" note for HttpBodyTooLargeError "Reports one backend-neutral limit failure"Test Plan