fix(epp): add opt-in gateway protocol compatibility - #13700
Conversation
Signed-off-by: Oxygen56 <jiangth99@163.com>
|
👋 Hi Oxygen56! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughChangesProtocol compatibility override
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This adds an opt-in gateway compatibility mode while keeping strict validation as the default, limiting the behavior change to explicitly enabled deployments. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Signed-off-by: Oxygen56 <jiangth99@163.com>
Overview:
Add an opt-in compatibility mode for gateways such as agentgateway that stream request bodies without waiting but omit the corresponding ext_proc capability flag. Strict validation remains the default so gateways that really wait for the header response still fail fast instead of deadlocking.
Details:
DYN_EPP_ALLOW_MISSING_SEND_BODY_WITHOUT_WAITING, defaulting tofalse.FULL_DUPLEX_STREAMED.Where should the reviewer start?
Start with the protocol validation and regression coverage in
deploy/inference-gateway/ext-proc/src/server.rs, then review the opt-in wiring indeploy/inference-gateway/ext-proc/src/runner.rsand the affected deployment setting indeploy/inference-gateway/ext-proc/examples/onramp/agg.yaml.Validation
dynamo-ext-proctest suite passed, including the gRPC compatibility stream regression.Related Issues
🔗 This PR is linked to an issue: