chore(runtime): register DYN_REQUEST_PLANE in environment_names - #13697
Open
nnshah1 wants to merge 1 commit into
Open
chore(runtime): register DYN_REQUEST_PLANE in environment_names#13697nnshah1 wants to merge 1 commit into
nnshah1 wants to merge 1 commit into
Conversation
DYN_REQUEST_PLANE selects the request-plane transport (tcp|nats) and is read by the runtime (lib/runtime/src/distributed.rs) and the Python launch layer, but it was referenced by a raw string literal and missing from the central environment_names registry — unlike its sibling DYN_REQUEST_PLANE_CODEC and every other DYN_* var. Add the const to the request_plane module, include it in the known-vars list, and have distributed.rs reference it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughChangesRequest-plane configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This is a localized configuration-name cleanup with unchanged runtime behavior; no actionable merge-blocking risk remains after normal checks, with the separate environment writer suitable for follow-up. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
rmccorm4
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DYN_REQUEST_PLANEselects the request-plane transport (tcp|nats) and is read by the runtime (lib/runtime/src/distributed.rs:835) and the Python launch layer (runtime_args.py,frontend_args.py,--request-plane). But on the Rust side it was referenced by a raw string literal and was missing from the centralenvironment_namesregistry — unlike its siblingDYN_REQUEST_PLANE_CODECand every otherDYN_*variable, which are defined aspub consts and listed in the known-vars set.This chore closes that gap:
pub const DYN_REQUEST_PLANEtoenvironment_names::request_plane(next toDYN_REQUEST_PLANE_CODEC).distributed.rsreference the const instead of the hardcoded string.No behavior change — same variable name and semantics; this just makes the registry complete and consistent.
Validation
cargo fmtclean on the touched files.lib/runtime/src/pipeline/network.rs(crate::config::environment_names::request_plane::DYN_REQUEST_PLANE_CODEC).🤖 Generated with Claude Code
Summary by CodeRabbit