Skip to content

chore(runtime): register DYN_REQUEST_PLANE in environment_names - #13697

Open
nnshah1 wants to merge 1 commit into
mainfrom
neelays/chore-dyn-request-plane-const
Open

chore(runtime): register DYN_REQUEST_PLANE in environment_names#13697
nnshah1 wants to merge 1 commit into
mainfrom
neelays/chore-dyn-request-plane-const

Conversation

@nnshah1

@nnshah1 nnshah1 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

DYN_REQUEST_PLANE selects the request-plane transport (tcp | nats) and is read by the runtime (lib/runtime/src/distributed.rs:835) and the Python launch layer (runtime_args.py, frontend_args.py, --request-plane). But on the Rust side it was referenced by a raw string literal and was missing from the central environment_names registry — unlike its sibling DYN_REQUEST_PLANE_CODEC and every other DYN_* variable, which are defined as pub consts and listed in the known-vars set.

This chore closes that gap:

  • Add pub const DYN_REQUEST_PLANE to environment_names::request_plane (next to DYN_REQUEST_PLANE_CODEC).
  • Include it in the known-vars list.
  • Have distributed.rs reference the const instead of the hardcoded string.

No behavior change — same variable name and semantics; this just makes the registry complete and consistent.

Validation

  • cargo fmt clean on the touched files.
  • Const reference mirrors the existing pattern in lib/runtime/src/pipeline/network.rs (crate::config::environment_names::request_plane::DYN_REQUEST_PLANE_CODEC).
  • Full compile via CI.

🤖 Generated with Claude Code


Open in Devin Review

Summary by CodeRabbit

  • Bug Fixes
    • Improved consistency when reading the request-plane configuration from the environment.
    • Preserved existing parsing and default behavior.

DYN_REQUEST_PLANE selects the request-plane transport (tcp|nats) and is read by
the runtime (lib/runtime/src/distributed.rs) and the Python launch layer, but it
was referenced by a raw string literal and missing from the central
environment_names registry — unlike its sibling DYN_REQUEST_PLANE_CODEC and every
other DYN_* var. Add the const to the request_plane module, include it in the
known-vars list, and have distributed.rs reference it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: nnshah1 <neelays@nvidia.com>
@nnshah1
nnshah1 requested a review from a team as a code owner August 23, 2026 18:48
@github-actions github-actions Bot added the chore label Aug 23, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 635ddba5-88bb-4c9b-b922-072067b7a5f4

📥 Commits

Reviewing files that changed from the base of the PR and between 004cd02 and 898ea97.

📒 Files selected for processing (2)
  • lib/runtime/src/config/environment_names.rs
  • lib/runtime/src/distributed.rs

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

Changes

Request-plane configuration

Layer / File(s) Summary
Centralize request-plane environment name
lib/runtime/src/config/environment_names.rs, lib/runtime/src/distributed.rs
The public request_plane::DYN_REQUEST_PLANE constant defines the environment variable name. RequestPlaneMode::from_env uses the constant, and duplicate-name test coverage includes it.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 898ea

This is a localized configuration-name cleanup with unchanged runtime behavior; no actionable merge-blocking risk remains after normal checks, with the separate environment writer suitable for follow-up.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the changes and validation, but it omits the required Related Issues section from the repository template. Add the required Related Issues section and either link the relevant issue or confirm that no related issue exists.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: registering DYN_REQUEST_PLANE in the runtime environment-name registry.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants