refactor(runtime): use OpenTelemetry trace propagation - #13688
Conversation
Signed-off-by: PeaBrane <yanrpei@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughTraceparent parsing now uses a shared OpenTelemetry propagator for multiple header formats. The shared extractor returns trace metadata, tracestate, request identifiers, and optional OTel context. Request and payload span constructors use this extraction path. ChangesTrace context extraction
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR centralizes trace propagation without changing the documented behavior, and its focused validation shows no material performance regression; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Summary
GenericHeaderExtractorwhile retaining exact W3C trace/span ID field-width checkstracestate, request-ID behavior, trace flags, and existing public helper signaturesValidation
cargo fmt --all -- --checkgit diff --check main..HEADThe stressed-point movement is minor and mixed rather than a material regression. Every trial used a fresh frontend/mocker topology, separate warmup, identical JSONL tracing, and disjoint CPU placement.
Summary by CodeRabbit
New Features
Bug Fixes