Skip to content

fix(memory): exclude rejected approaches from native memory - #76

Open
ahrav wants to merge 1 commit into
stack/anti-memory-01-corefrom
stack/anti-memory-02-rust
Open

fix(memory): exclude rejected approaches from native memory#76
ahrav wants to merge 1 commit into
stack/anti-memory-01-corefrom
stack/anti-memory-02-rust

Conversation

@ahrav

@ahrav ahrav commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Rust memory paths now fail closed around rejected approaches. Native state sync, rendering, and memory tools accept only explicit positive categories, so future negative categories cannot leak into agent memory by default.

This is the second PR in the anti-memory stack. It builds on the typed model in PR #75; PR #77 adds writers and PR #78 adds warning retrieval.

Design

  • Positive memory uses a shared category allow-list.
  • Native tool ingestion rejects anti-memory payloads.
  • Rendering omits rejected approaches even when mixed input reaches the boundary.

Validation

  • bun run check:all
  • Rust unit and contract tests for accepted and rejected categories

Stack created with GitHub Stacks CLIGive Feedback 💬

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 129c62fb-991b-49d5-a674-dd905b175467

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@ahrav ahrav changed the title fix(memory): reject negative claims in Rust fix(memory): exclude rejected approaches from native memory Aug 27, 2026
@ahrav
ahrav marked this pull request as ready for review August 27, 2026 15:20
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@kilo-code-bot

kilo-code-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • crates/mc-module/src/memory_render.rs
  • crates/mc-module/src/memory_tool.rs

Reviewed by gemini-3.7-flash · Input: 140K · Output: 18.4K · Cached: 762.5K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant