feat(cli): add managed daemon commands

[ahrav]

Summary

• add daemon start, stop, restart, status, and doctor commands
• expose stable magic-context.daemon/v1 JSON and human rendering
• bypass unrelated SQLite preflight for daemon operations

Stack

PR 8 of 10. Base: stack/mc-host-07-plugin-demand.

Validation

• CLI daemon command and dispatch tests
• CLI typecheck and build

Post-Deploy Monitoring & Validation

Watch command exit codes and reason/effect distributions for one release cycle. Roll back if status/doctor mutate state, JSON shape drifts, or restart effects disagree with observed lifecycle state. Owner: CLI maintainers.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

_{Comment @coderabbitai help to get the list of available commands.}

[claude]

isExecutableEntry() silently disables the whole CLI if realpathSync.native throws. The old index.ts always invoked main() unconditionally; now, on an install layout where process.argv[1] can't be realpath-resolved (ENOENT/EACCES, an unusual global-install symlink chain, or the bin file briefly missing during an atomic npm install), the catch swallows the error and this returns false. dispatchCli() is then never called, process.exitCode stays at its default 0, and the CLI silently does nothing instead of running the command or reporting an error.

No test exercises this exception path — index.test.ts only covers the "import as module" and "symlink success" cases. Consider at least logging/exiting non-zero when the realpath comparison throws, rather than treating it the same as "this is not the entry module."

[claude]

usageText() regresses --help output vs. the previous printUsage() in index.ts. Several lines present in the old implementation are missing here:

• the --dry-run tip under setup ("add --dry-run to preview the wizard without writing any files")
• the doctor --issue usage example
• the two-line doctor migrate --from opencode --to <pi|omp> --session ses_xxx --dry-run example
• the trailing "Waive a reviewed lineage failure" description after the --waive-claims-backfill-failure <id> --rationale "<why>" line (now cut off mid-sentence at line 72)

index.test.ts only asserts daemon actions and --json appear in the help text, so this regression isn't caught by tests. Worth restoring for parity, or confirming the drop was intentional.

[claude]

redactResult() and the stdout/renderDaemonHuman() call run outside the try block above (lines 136-144), which is the block that's supposed to guarantee "bounded stderr, no partial output" on failure (see the daemon.test.ts case "policy exceptions produce bounded stderr without a partial v1 object"). That guarantee is only tested for createPolicy/invoke throwing — if redactResult → sanitizeDiagnosticText ever throws (e.g. a future contract change or alternate DaemonPolicy implementation returns a versions field that isn't strictly string | null), the error propagates uncaught out of runDaemonCommand instead of hitting the bounded-stderr path.

Might be worth extending the try to cover redaction + rendering as well, so the "no partial/unredacted output" contract holds for the whole function, not just the policy call.

[claude]

Review summary

Reviewed feat(cli): add managed daemon commands (PR #55) for correctness, security, and code quality. Overall the refactor into dispatch.ts + daemon.ts is clean, well-tested (subprocess-level tests for the real entrypoint, redaction tests, bounded-stderr-on-failure tests), and the daemon result redaction/JSON contract is a good pattern. Three issues found, left as inline comments:

1. packages/cli/src/index.ts — the new isExecutableEntry() guard (added for import-safety) fails closed: if realpathSync.native throws for any reason, the CLI silently does nothing (exit code 0, no output) instead of running or erroring. The old code invoked main() unconditionally. No test covers this exception path.
2. packages/cli/src/dispatch.ts — usageText() dropped several --help lines that existed in the old printUsage(): the setup --dry-run tip, the doctor --issue example, the doctor migrate ... --dry-run example, and the trailing description on the --waive-claims-backfill-failure line (now truncated mid-sentence). Likely just needs porting over.
3. packages/cli/src/commands/daemon.ts — redactResult()/renderDaemonHuman()/stdout() run after the try/catch that's meant to guarantee bounded, redacted stderr on failure. If redaction itself ever throws, it escapes uncaught rather than hitting the bounded-stderr path the tests otherwise verify.

No security concerns beyond #3 (which is about failure-mode robustness, not an exploitable issue) — the redaction/sanitization approach for daemon output looks sound, and the SQLite-preflight bypass for daemon commands is scoped correctly (daemon short-circuits before the doctor preflight check, per dispatch.ts).