feat(release): add native mc-host payload packages - #51
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
| export function buildProductionPayloads(rootDir: string): never { | ||
| // Throws with the exact unqualified reason today (R26, KTD23). | ||
| requireQualificationEvidence(rootDir); | ||
| fail( | ||
| "production payload assembly requires qualified ORT/model bytes staged by " + | ||
| "release engineering; qualified inputs are locked but no assembly path is qualified yet", | ||
| ); | ||
| } |
There was a problem hiding this comment.
buildProductionPayloads calls requireQualificationEvidence(rootDir) purely for its throw-if-unqualified side effect, then unconditionally calls fail(...) right after regardless of the outcome. That means once release inputs actually become production-qualified, this function will still always throw ("no assembly path is qualified yet") with a misleading message, since nothing here branches on the qualification result. If a future PR flips production_qualified to true without also revisiting this function, bun scripts/build-mc-host-payload.ts (no flags) will keep failing closed for the wrong reason instead of proceeding to build. Worth a // TODO tying this to whichever follow-up ticket implements the real assembly path, so it's not forgotten.
Review summaryThis PR adds the three native Strengths
Minor finding (left as an inline comment)
Non-blocking observations
No security or correctness issues that block this PR; it does exactly what the description says (shells + fail-closed trust artifacts, no publish). |
Summary
Stack
PR 5 of 10. Base:
stack/mc-host-04-client-policy.Validation
Post-Deploy Monitoring & Validation
No packages are published by this PR. During target qualification, watch payload digest, package size, platform floor, and staging validation failures; block promotion on any mismatch. Owner: release maintainers.