fix(winget): declare the VC redistributable both CLIs need - #153
Merged
Conversation
muscariello
force-pushed
the
fix/winget-vcredist-dependency
branch
from
August 19, 2026 15:18
06f550e to
ece3008
Compare
Both binaries import VCRUNTIME140.dll; only shadictl got it, transitively via the OpenSSL dependency, so agentbridge failed validation. Signed-off-by: Luca Muscariello <muscariello@ieee.org>
muscariello
force-pushed
the
fix/winget-vcredist-dependency
branch
from
August 19, 2026 15:21
ece3008 to
15e3bd5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentbridge failed WinGet validation with
Validation-Executable-Error. Bothbinaries import
VCRUNTIME140.dll, which a clean Windows install lacks — onlyshadictl got it, transitively via
ShiningLight.OpenSSL.Light. Both packages nowdeclare it directly.
Our validation can't catch this: GitHub's Windows runners ship the
redistributable in System32.