fix(feedback_deliver): skip un-clonable repo instead of aborting the run - #24
Merged
Merged
Conversation
If `gh repo clone` failed (a non-submission whose repo was never created), `dest` didn't exist and the next `open(dest/FEEDBACK.md, "w")` raised FileNotFoundError, aborting the ENTIRE cohort delivery mid-run — every repo after the missing one was silently left undelivered. Guard on the clone + checkout-feedback exit codes: record the repo as `main_state="no-repo"` and continue. One missing repo no longer halts the cohort. Regression test: test_execute_skips_unclonable_repo_and_continues. Full suite green (399 passed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015cY2osrcunEXb5a8xtTy2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
gh repo clonefailed (a non-submission whose Classroom repo was never created),destwas never created and the nextopen(dest/FEEDBACK.md,"w")raisedFileNotFoundError, aborting the entire cohort delivery mid-run — every repo after the missing one was left undelivered. Hit live on the CECS 378 Lab 2 push (crashed at the first non-submission; 14/27 had delivered, the rest were stranded).Fix
Guard on the clone + checkout-feedback exit codes: record the repo as
main_state="no-repo"andcontinue. A single missing/empty repo no longer halts the cohort. Idempotent re-runs then complete cleanly.Test
test_execute_skips_unclonable_repo_and_continues— a failing clone is recorded as no-repo and the next repo still delivers. Full suite green — 399 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_015cY2osrcunEXb5a8xtTy2V